From 5fdde9d17792602773d5148eaf82e1c77f6448ae Mon Sep 17 00:00:00 2001
From: whidix <theodor.vallier@whidix.dev>
Date: Sat, 14 Mar 2026 18:34:03 +0100
Subject: [PATCH] refactor: remove unused fandomUrl and getDifferenceColor
 functions, simplify character link generation

---
 .../admin/character-changes/+page.svelte       | 18 +++---------------
 1 file changed, 3 insertions(+), 15 deletions(-)

diff --git a/src/routes/(admin)/admin/character-changes/+page.svelte b/src/routes/(admin)/admin/character-changes/+page.svelte
index 99ba52d..1a1242c 100644
--- a/src/routes/(admin)/admin/character-changes/+page.svelte
+++ b/src/routes/(admin)/admin/character-changes/+page.svelte
@@ -4,11 +4,6 @@
 	const newCharacters = $derived(data.changes.filter((c: any) => c.type === 'new'));
 	const modifiedCharacters = $derived(data.changes.filter((c: any) => c.type === 'modified'));
 
-	function fandomUrl(path: string | null | undefined): string {
-		if (!path) return 'https://onepiece.fandom.com/fr/wiki';
-		return `https://onepiece.fandom.com/fr/wiki/${path}`;
-	}
-
 	function formatValue(value: any): string {
 		if (value === null || value === undefined) {
 			return '—';
@@ -21,13 +16,6 @@
 		}
 		return String(value);
 	}
-
-	function getDifferenceColor(current: any, scraped: any): string {
-		if (JSON.stringify(current) === JSON.stringify(scraped)) {
-			return 'text-gray-400';
-		}
-		return 'text-amber-300';
-	}
 </script>
 
 <svelte:head>
@@ -78,7 +66,7 @@
 						<div class="flex items-center justify-between gap-3">
 							<div class="flex items-center gap-3">
 								{#if change.scraped.pictureUrl}
-									<a href={fandomUrl(change.scraped.url)} target="_blank" rel="noopener noreferrer">
+									<a href="https://onepiece.fandom.com/fr/wiki/{change.scraped.url}" target="_blank" rel="noopener noreferrer">
 										<img
 											src={change.scraped.pictureUrl}
 											alt={change.scraped.name}
@@ -137,7 +125,7 @@
 						<div class="flex items-center justify-between gap-3 pb-4 border-b border-amber-500/20">
 							<div class="flex items-center gap-3">
 								{#if change.current?.pictureUrl}
-									<a href={fandomUrl(change.current?.url ?? change.scraped.url)} target="_blank" rel="noopener noreferrer">
+									<a href="https://onepiece.fandom.com/fr/wiki/{change.current?.url ?? change.scraped.url}" target="_blank" rel="noopener noreferrer">
 										<img
 											src={change.current.pictureUrl}
 											alt={change.current.name}
@@ -163,7 +151,7 @@
 
 						{#if change.differences}
 							<div class="space-y-3">
-								{#each Object.entries(change.differences) as [field, diff]}
+								{#each Object.entries(change.differences) as [field, diff] (field)}
 									<div class="bg-slate-900/50 rounded p-3 space-y-1">
 										<h4 class="text-sm font-semibold text-amber-100 uppercase tracking-widest">{field}</h4>
 										<div class="grid grid-cols-2 gap-4 text-sm">