Refactor code structure for improved readability and maintainability

scripts/import-json.ts

@@ -4,6 +4,8 @@ import { sql, eq } from 'drizzle-orm';
 import fs from 'fs';
 import { arc, character, devilFruit, characterScrapeValidation, type DevilFruitType } from '../src/lib/server/db/schema';
 
+type Status = 'Alive' | 'Dead' | 'Unknown';
+
 type ArcRecord = {
 	id: string;
 	name: string;
@@ -22,9 +24,11 @@ type DevilFruitRecord = {
 type CharacterRecord = {
 	id: string;
 	name: string;
+	frName?: string | null;
 	gender?: string | null;
 	age?: number | null;
 	affiliations?: string[] | string | null;
+	frAffiliations?: string[] | string | null;
 	devilFruitId?: string | null;
 	hakiObservation?: boolean;
 	hakiArmament?: boolean;
@@ -32,12 +36,15 @@ type CharacterRecord = {
 	bounty?: number | null;
 	height?: number | null;
 	origin?: string | null;
+	frOrigin?: string | null;
 	firstAppearance?: number;
 	pictureUrl?: string | null;
 	epithets?: string[] | string | null;
-	status?: string | null;
+	frEpithets?: string[] | string | null;
+	status?: Status | null;
 	arcId?: string | null;
 	url?: string | null;
+	frUrl?: string | null;
 };
 
 const DATABASE_URL = process.env.DATABASE_URL || 'file:local.db';
@@ -86,7 +93,7 @@ function toJsonArray(value: string[] | string | null | undefined): string[] | nu
 
 function toDevilFruitType(value: DevilFruitType | string | null | undefined): DevilFruitType | null {
 	if (!value) return null;
-	if (value === 'Paramecia' || value === 'Zoan' || value === 'Logia' || value === 'Unknown') {
+	if (value === 'Paramecia' || value === 'Zoan' || value === 'Logia' || value === 'Smile' || value === 'Unknown') {
 		return value;
 	}
 	return 'Unknown';
@@ -115,59 +122,25 @@ function transformCharacterData(item: CharacterRecord) {
 		gender: toNullable(item.gender),
 		age: toNullable(item.age),
 		affiliations: toJsonArray(item.affiliations),
+		frAffiliations: toJsonArray(item.frAffiliations),
 		devilFruitId: toNullable(item.devilFruitId),
 		hakiObservation: !!item.hakiObservation,
 		hakiArmament: !!item.hakiArmament,
 		hakiConqueror: !!item.hakiConqueror,
 		bounty: item.bounty ?? 0,
-		height: toNumber(item.height as any),
+		height: toNumber(item.height as string | number | null),
 		origin: toNullable(item.origin),
+		frOrigin: toNullable(item.frOrigin),
 		firstAppearance: item.firstAppearance ?? 0,
 		pictureUrl: toNullable(item.pictureUrl),
 		epithets: toJsonArray(item.epithets),
+		frEpithets: toJsonArray(item.frEpithets),
 		status: toNullable(item.status),
 		arcId: toNullable(item.arcId),
 		url: toNullable(item.url)
 	};
 }
 
-function hasChanged(jsonData: any, dbData: any): boolean {
-	if (!dbData) return true;
-
-    // Print any differences for debugging
-    for (const key in jsonData) {
-        const jsonValue = jsonData[key];
-        const dbValue = dbData[key];
-        const jsonString = typeof jsonValue === 'object' ? JSON.stringify(jsonValue) : String(jsonValue);
-        const dbString = typeof dbValue === 'object' ? JSON.stringify(dbValue) : String(dbValue);
-        if (jsonString !== dbString) {
-            console.log(`\nField "${key}" changed for character ID ${jsonData.id}:`);
-            console.log(`  JSON: ${jsonString}`);
-            console.log(`  DB:   ${dbString}`);
-        }   }
-	
-	// Compare each field
-	return (
-		jsonData.name != dbData.name ||
-		jsonData.gender != dbData.gender ||
-		jsonData.age != dbData.age ||
-		JSON.stringify(jsonData.affiliations) != JSON.stringify(dbData.affiliations) ||
-		jsonData.devilFruitId != dbData.devilFruitId ||
-		jsonData.hakiObservation != dbData.hakiObservation ||
-		jsonData.hakiArmament != dbData.hakiArmament ||
-		jsonData.hakiConqueror != dbData.hakiConqueror ||
-		jsonData.bounty != dbData.bounty ||
-		jsonData.height != dbData.height ||
-		jsonData.origin != dbData.origin ||
-		jsonData.firstAppearance != dbData.firstAppearance ||
-		jsonData.pictureUrl != dbData.pictureUrl ||
-		JSON.stringify(jsonData.epithets) != JSON.stringify(dbData.epithets) ||
-		jsonData.status != dbData.status ||
-		jsonData.arcId != dbData.arcId ||
-		jsonData.url != dbData.url
-	);
-}
-
 async function isCharacterTableEmpty(): Promise<boolean> {
 	const result = await db.select({ count: sql<number>`COUNT(*)` }).from(character);
 	return result[0]?.count === 0;